Re: [PATCH 5/5] spi: fix return value check in hspi_probe().

[PATCH 0/5] Use IS_ERR() rather than a NULL check when necessary. · Cyril Roelandt <hidden> · 2012-12-12
[PATCH 3/5] c2port: fix return value check in duramar2150_c2port_init(). · Cyril Roelandt <hidden> · 2012-12-12
[PATCH 5/5] spi: fix return value check in hspi_probe(). · Cyril Roelandt <hidden> · 2012-12-12
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> · 2012-12-12
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Grant Likely <hidden> · 2012-12-19
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Dan Carpenter <hidden> · 2012-12-19
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Grant Likely <hidden> · 2012-12-22
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Dan Carpenter <hidden> · 2013-01-03
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Grant Likely <hidden> · 2013-01-11
Re: [PATCH 5/5] spi: fix return value check in hspi_probe(). · Dan Carpenter <hidden> · 2013-01-12
[PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel(). · Cyril Roelandt <hidden> · 2012-12-12
Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel(). · David Miller <davem@davemloft.net> · 2012-12-12
Re: [PATCH 4/5] net: sfc: fix return value check in efx_ptp_probe_channel(). · Ben Hutchings <hidden> · 2012-12-21
[PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs(). · Cyril Roelandt <hidden> · 2012-12-12
Re: [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs(). · Prabhakar Lad <prabhakar.csengg@gmail.com> · 2012-12-12
[PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling(). · Cyril Roelandt <hidden> · 2012-12-12
Re: [PATCH 1/5] staging: omap-thermal: fix error check in omap_thermal_expose_sensor() and in omap_thermal_register_cpu_cooling(). · Eduardo Valentin <hidden> · 2012-12-12

From: Dan Carpenter <hidden>
Date: 2012-12-19 16:39:48
Also in: linux-spi, lkml

On Wed, Dec 19, 2012 at 03:11:54PM +0000, Grant Likely wrote:

On Tue, 11 Dec 2012 16:36:27 -0800 (PST), Kuninori Morimoto [off-list ref] wrote:

quoted

Hi

quoted

According to its documentation, clk_get() returns a "valid IS_ERR() condition
containing errno", so we should call IS_ERR() rather than a NULL check.

Signed-off-by: Cyril Roelandt <redacted>

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Applied, thanks.

In another thread, we were just talking about who clk_get() can
return a NULL if !CONFIG_HAVE_CLK.  That might change to match the
documentation later...  Not sure.

regards,
dan carpenter

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help