Thread (16 messages) 16 messages, 5 authors, 2021-11-01

Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings

From: Randy Dunlap <hidden>
Date: 2021-10-08 19:47:05
Also in: lkml

On 10/8/21 11:39 AM, Rob Landley wrote:
On 10/4/21 7:19 PM, Randy Dunlap wrote:
quoted
kernel.h defines READ and WRITE, so rename the SH math-emu macros
to MREAD and MWRITE.
This one doesn't apply for me. My file has:

#define WRITE(d,a)      ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;})

But your patch tries to remove:

-#define WRITE(d,a)     ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;})

Which is odd because git log says my tree is current as of today, but git log on
this file says it was last updated:

commit 2e1661d2673667d886cd40ad9f414cb6db48d8da
Author: Eric W. Biederman [off-list ref]
Date:   Thu May 23 11:04:24 2019 -0500

What did I miss?
Hi Rob,

I am making patches to linux-next, which contains this:

commit ca42bc4b7bda
Author: Al Viro [off-list ref]
Date:   Thu Dec 31 23:23:01 2020 +0000

     sh: fix trivial misannotations

which adds the __user annotations...


-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help