Thread (16 messages) 16 messages, 5 authors, 2021-11-01

Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions

From: Randy Dunlap <hidden>
Date: 2021-10-06 01:06:35
Also in: lkml

On 10/5/21 12:26 AM, Geert Uytterhoeven wrote:
Hi Randy,

Thanks for your patch!

On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap [off-list ref] wrote:
quoted
Delete ieee_fpe_handler() since it is not used. After that is done,
delete denormal_to_double() since it is not used:

../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
   505 | static int ieee_fpe_handler(struct pt_regs *regs)

../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
   477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)

Fixes: 4b565680d163 ("sh: math-emu support")
Shouldn't that be
Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
?
oh, ah, um. Yes, it should. Thanks!
quoted
Signed-off-by: Randy Dunlap <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                         Geert

-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help