On Fri, 19 Aug 2011, Simon Horman wrote:

On Fri, Aug 19, 2011 at 03:51:49PM +0900, Magnus Damm wrote:

quoted

On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman [off-list ref] wrote:

[snip]

quoted

quoted

As we are already on the slippery slope of allowing combinations
other than 1 (legacy) or 3 (specific) IRQ sources I plan to implement
a variant of your flag idea. The variation being to use names instead
because a) that allows the use of platform_get_irq_byname() and b)
the flags bits seem to be full and not driver-specific.

Great, platform_get_irq_byname() seems like a perfect match.

May I suggest "hotplug", "data" and "sdio" as names? I don't care very
much about names except keeping them short and precise to prevent
errors that can only be caught during runtime.

Earlier on in the life of this series Guennadi suggested
the names "card_detect", "sdcard" and "sdio". While I am
not particularly attached to those names the do seem
reasonable and are already used consistently by this series.
So I would prefer to use those names.

Just one more thing I forgot to mention in the previous mail: using names 
also makes the transition simple: first patch all platforms with names (at 
least those with multiple IRQs, if your legacy fallback implementation 
will accept unnamed IRQs), and then patch sh_mobile_sdhi.c

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/