On Fri, 19 Aug 2011, Magnus Damm wrote:

On Fri, Aug 19, 2011 at 3:39 PM, Simon Horman [off-list ref] wrote:

[snip]

quoted

As we are already on the slippery slope of allowing combinations
other than 1 (legacy) or 3 (specific) IRQ sources I plan to implement
a variant of your flag idea. The variation being to use names instead
because a) that allows the use of platform_get_irq_byname() and b)
the flags bits seem to be full and not driver-specific.

Great, platform_get_irq_byname() seems like a perfect match.

Indeed, good idea! This API is (unfortunately) so rarely used, that it was  
pretty much completely absent from my "active dictionary."

May I suggest "hotplug", "data" and "sdio" as names? I don't care very
much about names except keeping them short and precise to prevent
errors that can only be caught during runtime.

I don't care about names all that much either, but as Simon suggested in 
his other mail, consistency is good. Besides, yes, I thought about "data"
as a name for the main SDHI IRQ, but I decided it didn't reflect its 
function very well. Firstly, it is not only data, secondly, SDIO IRQs can 
also announce data availability, I think. The even more precise 
description of these two IRQs would be, perhaps, "synchronous" and 
"asynchronous," but that's probably not very intuitivy.

So, I'll accept any names, that you two agree upon:-)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/