Hi Geert-san,

Thank you for your review!

From: Geert Uytterhoeven, Sent: Friday, November 19, 2021 2:54 AM

On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda
[off-list ref] wrote:

quoted

Add device tree bindings documentation for Renesas R-Car S4-8
Spider CPU and BreakOut boards.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

quoted

--- a/Documentation/devicetree/bindings/arm/renesas.yaml
+++ b/Documentation/devicetree/bindings/arm/renesas.yaml

@@ -317,6 +317,14 @@ properties:

       - description: R-Car S4-8 (R8A779F0)
         items:
+          - enum:
+              - renesas,spider-cpu # Spider CPU board (RTP8A779FASKB0SC2S)

I realized that the part number should be RTP8A779F0ASKB0SC2S.
                                                   ~
I'll fix it in v2.

quoted

+          - const: renesas,r8a779f0
+
+        items:

Missing "-" in front of "items:".

Oops. I'll fix it.

quoted

+          - enum:
+              - renesas,spider-breakout # Spider BreakOut board (RTP8A779F0ASKB0SB0S)
+          - const: renesas,spider-cpu
           - const: renesas,r8a779f0

       - description: R-Car H3e (R8A779M0)

The rest LGTM.
Reading[1], I assume "RTP8A779F0ASKB0SP2S" is the part number of the
full kit?

Yes, your assumption is correct.

Best regards,
Yoshihiro Shimoda