Re: [PATCH 1/3] dt-bindings: serial: renesas,scif: Make resets as a required property

Hi Geert,

Thank you for the review.

On Mon, Nov 8, 2021 at 4:29 PM Geert Uytterhoeven [off-list ref] wrote:

On Wed, Nov 3, 2021 at 6:31 PM Lad Prabhakar
[off-list ref] wrote:

quoted

Make "resets" as required property for RZ/G2L. On RZ/G2L the devices
should be explicitly pulled out of reset for this reason make "resets"
as required property.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

quoted

--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml

@@ -151,6 +151,7 @@ if:
     compatible:
       contains:
         enum:
+          - renesas,scif-r9a07g044
           - renesas,rcar-gen2-scif
           - renesas,rcar-gen3-scif

People might prefer alphabetical sort order...

My intention was to keep the generic ones at the end as we do for
compatible property.  Let me know if you still want me to change it.

Cheers,
Prabhakar

quoted

 then:

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds