Re: [PATCH 2/3] dt-bindings: serial: renesas,sci: Document RZ/G2L SoC
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-11-08 16:19:45
Also in:
linux-devicetree, linux-renesas-soc, lkml
Hi Prabhakar, On Wed, Nov 3, 2021 at 6:31 PM Lad Prabhakar [off-list ref] wrote:
Add SCI binding documentation for Renesas RZ/G2L SoC. Also update the example node with real world DT node. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
quoted hunk ↗ jump to hunk
--- a/Documentation/devicetree/bindings/serial/renesas,sci.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,sci.yaml@@ -14,7 +14,11 @@ allOf: properties: compatible: - const: renesas,sci + oneOf: + - items: + - enum: + - renesas,r9a07g044-sci # RZ/G2{L,LC} + - const: renesas,sci # generic SCI compatible UART
You added a oneOf, but forgot to keep the old single compatible value as used on H8/300?
reg:
maxItems: 1
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds