Re: [PATCH v3 4/4] tty: make use of tty_get_{char,frame}_size
From: Alex Elder <hidden>
Date: 2021-06-10 15:16:02
Also in:
lkml
From: Alex Elder <hidden>
Date: 2021-06-10 15:16:02
Also in:
lkml
On 6/10/21 4:02 AM, Jiri Slaby wrote:
In the previous patch, we introduced tty_get_char_size() and tty_get_frame_size() for computing character and frame sizes, respectively. Here, we make use of them in various tty drivers where applicable. The stats look nice: 12 insertions, 169 deletions.
Agreed. Looks good to me (for drivers/staging/greybus/uart.c). Acked-by: Alex Elder <elder@kernel.org>
Signed-off-by: Jiri Slaby <redacted> Cc: Arnd Bergmann <arnd@arndb.de> Cc: David Lin <dtwlin@gmail.com> Cc: Johan Hovold <johan@kernel.org> Cc: Alex Elder <elder@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <redacted> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Oliver Neukum <oneukum@suse.com>