Thread (61 messages) 61 messages, 10 authors, 2021-03-15

Re: [PATCH 37/44] USB: serial/keyspan, drop unneeded forward declarations

From: Johan Hovold <johan@kernel.org>
Date: 2021-03-15 08:43:52
Also in: lkml

On Wed, Mar 03, 2021 at 08:17:11PM +0100, Greg Kroah-Hartman wrote:
On Tue, Mar 02, 2021 at 07:22:07AM +0100, Jiri Slaby wrote:
quoted
Forward declarations make the code larger, harder to follow and rewrite.
Harder as the declarations are often omitted from global changes. Remove
forward declarations which are not really needed, i.e. when the
definition of the function is before its first use.

Signed-off-by: Jiri Slaby <redacted>
Cc: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/keyspan.c | 20 --------------------
 1 file changed, 20 deletions(-)
I'll let Johan take this through his tree:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Now applied.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help