Re: [PATCH 34/44] tty: do not check tty_unregister_driver's return value
From: Max Filippov <jcmvbkbc@gmail.com>
Date: 2021-03-02 08:28:19
Also in:
lkml
From: Max Filippov <jcmvbkbc@gmail.com>
Date: 2021-03-02 08:28:19
Also in:
lkml
On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby [off-list ref] wrote:
These drivers check tty_unregister_driver return value. But they don't handle a failure correctly (they free the driver in any case). So stop checking tty_unregister_driver return value and remove also the prints. In the next patch, tty_unregister_driver's return type will be switched to void. Signed-off-by: Jiri Slaby <redacted> Cc: Chris Zankel <chris@zankel.net> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: linux-xtensa@linux-xtensa.org Cc: Jiri Kosina <jikos@kernel.org> Cc: David Sterba <dsterba@suse.com> --- arch/xtensa/platforms/iss/console.c | 6 +----- drivers/tty/amiserial.c | 8 ++------ drivers/tty/ipwireless/tty.c | 7 +------ drivers/tty/moxa.c | 4 +--- drivers/tty/serial/kgdb_nmi.c | 4 +--- drivers/tty/synclink_gt.c | 5 +---- 6 files changed, 7 insertions(+), 27 deletions(-)
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com> -- Thanks. -- Max