Thread (27 messages) 27 messages, 4 authors, 2018-07-13

Re: [PATCH v2] uart: fix race between uart_put_char() and uart_shutdown()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2018-07-06 14:39:29
Also in: lkml

On Fri, Jun 29, 2018 at 10:43:30AM -0600, Tycho Andersen wrote:
On Fri, Jun 29, 2018 at 04:24:46AM -0600, Tycho Andersen wrote:
quoted
v2: switch to locking uport->lock on allocation/deallocation instead of
    locking the per-port mutex in uart_put_char. Note that since
    uport->lock is a spin lock, we have to switch the allocation to
    GFP_ATOMIC.
Serge pointed out off-list that we may want to do the allocation
before the lock so that it's more likely to be successful. I'm happy
to send that change to this if it's what we want to do, I don't have a
strong preference.
That sounds like a much better thing to do.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help