Re: [PATCH v2 4/7] serial: sh-sci: increase RX FIFO trigger defaults for (H)SCIF
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-01-24 08:00:44
Also in:
linux-renesas-soc
On Mon, Jan 23, 2017 at 5:04 PM, Ulrich Hecht [off-list ref] wrote:
Signed-off-by: Ulrich Hecht <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
quoted hunk ↗ jump to hunk
@@ -2736,15 +2742,19 @@ static int sci_init_single(struct platform_device *dev, sci_port->sampling_rate_mask = SCI_SR_SCIFAB; break; case PORT_SCIF: - port->fifosize = 16; if (p->regtype == SCIx_SH7705_SCIF_REGTYPE) { + port->fifosize = 64;
Note that you forgot to mention that you also corrected the FIFO size for sh7705, ssh7720, and sh7721. Not that we can easily test that, though.
sci_port->overrun_reg = SCxSR;
sci_port->overrun_mask = SCIFA_ORER;
sci_port->sampling_rate_mask = SCI_SR(16);
+ /* RX triggering not implemented for this IP */
+ sci_port->rx_trigger = 1;
} else {
+ port->fifosize = 16;
sci_port->overrun_reg = SCLSR;
sci_port->overrun_mask = SCLSR_ORER;
sci_port->sampling_rate_mask = SCI_SR(32);
+ sci_port->rx_trigger = 8;
}
break;
default:
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds