Re: [PATCH v2 7/7] arm64: dts: r8a7796: salvator-x: add SCIF1 (DEBUG1)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-01-24 08:08:24
Also in:
linux-renesas-soc
Hi Uli, On Mon, Jan 23, 2017 at 5:04 PM, Ulrich Hecht [off-list ref] wrote:
Enables the SCIF hooked up to the DEBUG1 connector. Signed-off-by: Ulrich Hecht <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index c7f40f8..498d971 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts@@ -18,6 +18,7 @@ aliases { serial0 = &scif2; + serial1 = &scif1;
While the patch is acceptable as-is, my question is still valid:
Is there any specific reason you chose scif1 over hscif1?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds