Re: [PATCH] tty: Correct tty buffer flushing.
From: Peter Hurley <hidden>
Date: 2012-11-30 01:14:30
Also in:
lkml
From: Peter Hurley <hidden>
Date: 2012-11-30 01:14:30
Also in:
lkml
On Thu, 2012-11-29 at 21:28 +0000, Alan Cox wrote:
quoted
Sorry, In you reply not all patch. Main idea here - we never flash last (struct tty_buffer) in the active buffer. Only data for ldisc. (tty->buf.head->read = tty->buf.head->commit). At that moment driver can collect(write) data in buffer without conflict.Ah.. now I understand. Yes that makes sense. I will think about that carefully. This is why a good explanation with a patch is important.
FWIW, I've been running this on -next. The logic seems sound to me -- fundamentally, this technique is what flush_to_ldisc() does. Regards, Peter Hurley