Re: [PATCH] tty: Correct tty buffer flushing.
From: Alan Cox <hidden>
Date: 2012-11-29 13:49:53
Also in:
lkml
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index 6c9b7cd..4f02f9c 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c@@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) { struct tty_buffer *thead; - while ((thead = tty->buf.head) != NULL) { - tty->buf.head = thead->next; - tty_buffer_free(tty, thead); + if (tty->buf.head == NULL) + return; + while ((thead = tty->buf.head->next) != NULL) { + tty_buffer_free(tty, tty->buf.head); + tty->buf.head = thead;
This part of the change seems to have no effect at all. There are no locks held so there is nothing guaranteeing how the other processors views of the order of operations will be affected. Alan