On Fri, Oct 12, 2012 at 09:35:54AM -0700, Kevin Hilman wrote:

Sourav [off-list ref] writes:

quoted

diff --git a/drivers/tty/serial/omap-serial.c

b/drivers/tty/serial/omap-serial.c
index 6ede6fd..3fbc7f7 100644

--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c

@@ -1414,6 +1414,7 @@ static int __devinit serial_omap_probe(struct

platform_device *pdev)
        INIT_WORK(&up->qos_work, serial_omap_uart_qos_work);

        platform_set_drvdata(pdev, up);
+       pm_runtime_set_active(&pdev->dev);

NAK.

This will obviously break platforms where the UARTs are not active
before driver loads.

I thought I had proposed a solution for this issue, which was this
sequence:

        omap_device_enable(dev);                                                
        pm_runtime_set_active(dev);                                             
        pm_runtime_enable(dev);                                                 

Yes, I can understand people not liking the omap_device_enable()
there, but I also notice that the email suggesting that never got a
reply either - not even a "I tried this and it doesn't work" or "it
does work".

As such, it seems this issue isn't making any progress as we had
already established that merely doing a "pm_runtime_set_active()"
before "pm_runtime_enable()" was going to break other platforms.