Alan,

I am not sure if you got my last email, so I'm resending it now:

 > I am very sorry, but I don't see it. We didn't held the lock while 
calling tty_audit_push() before, and we don't hold it after the patch 
neither.
 > So what's the locking scheme change here? Is there some binding 
between n_tty_read() and tty_audit_push() I just don't see?

Please can you advice me why I should check this patch with audit folks?

Thanks a lot,
-Stanislav

 >> Looks good to me. However it changes the locking rules on
 >> tty_audit_push() so please check the audit folks are ok with it. I don't
 >> think that causes any problems.
 >>
 >> Alan