Thread (25 messages) 25 messages, 3 authors, 2012-08-16

Re: Patch for panic in n_tty_read()

From: Stanislav Kozina <hidden>
Date: 2012-07-30 11:59:03

Alan,

I am very sorry, but I don't see it. We didn't held the lock while 
calling tty_audit_push() before, and we don't hold it after the patch 
neither.
So what's the locking scheme change here? Is there some binding between 
n_tty_read() and tty_audit_push() I just don't see?

Thank you,
-Stanislav
Looks good to me. However it changes the locking rules on
tty_audit_push() so please check the audit folks are ok with it. I don't
think that causes any problems.

Alan
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help