Re: Patch for panic in n_tty_read()
From: Stanislav Kozina <hidden>
Date: 2012-07-30 11:59:03
From: Stanislav Kozina <hidden>
Date: 2012-07-30 11:59:03
Alan, I am very sorry, but I don't see it. We didn't held the lock while calling tty_audit_push() before, and we don't hold it after the patch neither. So what's the locking scheme change here? Is there some binding between n_tty_read() and tty_audit_push() I just don't see? Thank you, -Stanislav
Looks good to me. However it changes the locking rules on tty_audit_push() so please check the audit folks are ok with it. I don't think that causes any problems. Alan