Thread (26 messages) 26 messages, 11 authors, 2011-11-14

Re: [PATCH] atmel_serial: RS485: receiving enabled when sending data

From: Russell King - ARM Linux <hidden>
Date: 2011-08-23 10:24:55
Also in: linux-arm-kernel, lkml

On Tue, Aug 23, 2011 at 11:14:38AM +0100, Alan Cox wrote:
quoted
atmel_serial: RS485: receiving enabled when sending data

By default the atmel_serial driver in RS485 mode disables receiving data until
all data in the send buffer has been sent. This flag allows to receive data
even whilst sending data.

Signed-off-by: Bernhard Roth <redacted> 
Signed-off-by: Claudio Scordino <redacted>
Acked-by: Alan Cox <redacted>

(although when we have people having a serious meta discussion about four
 spaces, or a tab or neither rather than functionality I despair)
We could ignore it, but then we end up with code being randomly
formatted throughout files, which makes it _more_ likely that the
code will be misread later.  That in turn makes the chances of
bugs introduced more likely in the future.

It also encourages 'cleanup' patches further down the line, so more
churn - which is something that Linus has been complaining about,
particularly in regard to ARM stuff.

It's far better to get things right the first time round than have
to keep touching stuff time and time again - either because of
cleanup patches or because of subtle bugs introduced by misreading
the code.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help