Thread (17 messages) 17 messages, 3 authors, 2011-06-09
STALE5484d

Re: [PATCH v3 04/12] Serial: OMAP: Add runtime pm support for omap-serial driver

From: Govindraj <hidden>
Date: 2011-06-09 04:35:47
Also in: linux-arm-kernel, linux-omap

On Thu, Jun 9, 2011 at 2:09 AM, Jon Hunter [off-list ref] wrote:
Hi Govindraj,

On 6/8/2011 6:23 AM, Govindraj.R wrote:

[snip]
quoted
+
+#define OMAP_UART_AUTOSUSPEND_DELAY (30 * HZ) /* Value is msecs */
[snip]
quoted
@@ -1295,18 +1381,36 @@ static int serial_omap_probe(struct
platform_device *pdev)
               up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE;
       }

+       pm_runtime_use_autosuspend(&pdev->dev);
+       pm_runtime_set_autosuspend_delay(&pdev->dev,
+                       OMAP_UART_AUTOSUSPEND_DELAY);
Something is weird here...DEFAULT_AUTOSUSPEND_DELAY is defined as (30*HZ)
which would appear to be jiffies (ticks per second) and NOT msecs. However,
pm_runtime_set_autosuspend is clearly expecting msecs. So this seems to
conflict. By default 30*HZ for omap would be 30*128 = 3840ms so not quite 4
seconds.

What were you intending here?
Intention is to get approx 3 secs timeout for autosuspend.

--
Thanks,
Govindraj.R
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help