Re: [PATCH v2 3/6] KEYS: Prevent overflow of user->{qnkeys,qnbytes} in key_alloc()

From
Jarkko Sakkinen <jarkko@kernel.org>
Date
2026-10-19 20:53:17
Also in
keyrings, lkml, stable
Reply to
Eric Biggers, 2026-10-19
On Mon, Oct 19, 2026 at 12:23:32PM -0700, Eric Biggers wrote:
On Mon, Oct 19, 2026 at 09:17:23PM +0300, Jarkko Sakkinen wrote:
quoted
Add the missing overflow checks for user->qnkeys and user->qnbytes
in order keep calculations within INT_MAX range, which is the
absolute maximum quota.

Cc: <redacted>
Assisted-by: LLM
Fixes: 7e047ef5fe2d ("[PATCH] keys: sort out key quota system")
Reviewed-by: David Howells <dhowells@redhat.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Don't keyctl_chown_key() and key_payload_reserve() need similar fixes?
Thanks, I'll investigate.

Unless any specific reason, I would not hold merging this series. I have
written down a follow-up backlog i.e., post-tasks once this series is
merged.
- Eric
Br, Jarkko
Thread (32 messages) 32 messages, 3 authors, last reply 29d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help