Re: [PATCH 51/61] security: update audit format strings for u64 i_ino
From: Paul Moore <paul@paul-moore.com>
Date: 2026-02-26 21:11:54
Also in:
amd-gfx, autofs, ceph-devel, linux-cifs, linux-ext4, linux-f2fs-devel, linux-fscrypt, linux-fsdevel, linux-hams, linux-integrity, linux-media, linux-mm, linux-nfs, linux-perf-users, linux-trace-kernel, linux-unionfs, linux-xfs, lkml, netdev, netfs, ntfs3, nvdimm, ocfs2-devel, selinux, v9fs
On Thu, Feb 26, 2026 at 11:06 AM Jeff Layton [off-list ref] wrote:
Update %lu/%ld to %llu/%lld in security audit logging functions that print inode->i_ino, since i_ino is now u64. Files updated: apparmor/apparmorfs.c, integrity/integrity_audit.c, ipe/audit.c, lsm_audit.c. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- security/apparmor/apparmorfs.c | 4 ++-- security/integrity/integrity_audit.c | 2 +- security/ipe/audit.c | 2 +- security/lsm_audit.c | 10 +++++----- security/selinux/hooks.c | 4 ++-- security/smack/smack_lsm.c | 12 ++++++------ 6 files changed, 17 insertions(+), 17 deletions(-)
...
quoted hunk ↗ jump to hunk
diff --git a/security/lsm_audit.c b/security/lsm_audit.c index 7d623b00495c14b079e10e963c21a9f949c11f07..737f5a263a8f79416133315edf363ece3d79c722 100644 --- a/security/lsm_audit.c +++ b/security/lsm_audit.c
Everything in security/lsm_audit.c looks okay.
quoted hunk ↗ jump to hunk
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index d8224ea113d1ac273aac1fb52324f00b3301ae75..150ea86ebc1f7c7f8391af4109a3da82b12d00d2 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c@@ -1400,7 +1400,7 @@ static int inode_doinit_use_xattr(struct inode *inode, struct dentry *dentry, if (rc < 0) { kfree(context); if (rc != -ENODATA) { - pr_warn("SELinux: %s: getxattr returned %d for dev=%s ino=%ld\n", + pr_warn("SELinux: %s: getxattr returned %d for dev=%s ino=%lld\n", __func__, -rc, inode->i_sb->s_id, inode->i_ino); return rc; }
Additionally, later in this function there are pr_notice_ratelimited() and pr_warn() calls that print inode numbers and need to be updated. -- paul-moore.com