Re: [PATCH 25/61] ceph: update format strings for u64 i_ino
From: Viacheslav Dubeyko <hidden>
Date: 2026-02-26 19:38:17
Also in:
amd-gfx, autofs, ceph-devel, linux-cifs, linux-ext4, linux-f2fs-devel, linux-fscrypt, linux-fsdevel, linux-hams, linux-integrity, linux-media, linux-mm, linux-nfs, linux-perf-users, linux-trace-kernel, linux-unionfs, linux-xfs, lkml, netdev, netfs, ntfs3, nvdimm, ocfs2-devel, selinux, v9fs
On Thu, 2026-02-26 at 10:55 -0500, Jeff Layton wrote:
quoted hunk ↗ jump to hunk
Update format strings and local variable types in ceph for the i_ino type change from unsigned long to u64. Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ceph/crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c index f3de43ccb470ddbd7945426d79f9024ae615c127..3c8a21a572d8230b558f20bb02721184cae35ee6 100644 --- a/fs/ceph/crypto.c +++ b/fs/ceph/crypto.c@@ -272,7 +272,7 @@ int ceph_encode_encrypted_dname(struct inode *parent, char *buf, int elen) /* To understand the 240 limit, see CEPH_NOHASH_NAME_MAX comments */ WARN_ON(elen > 240); if (dir != parent) // leading _ is already there; append _<inum> - elen += 1 + sprintf(p + elen, "_%ld", dir->i_ino); + elen += 1 + sprintf(p + elen, "_%lld", dir->i_ino); out: kfree(cryptbuf);@@ -377,7 +377,7 @@ int ceph_fname_to_usr(const struct ceph_fname *fname, struct fscrypt_str *tname, if (!ret && (dir != fname->dir)) { char tmp_buf[BASE64_CHARS(NAME_MAX)]; - name_len = snprintf(tmp_buf, sizeof(tmp_buf), "_%.*s_%ld", + name_len = snprintf(tmp_buf, sizeof(tmp_buf), "_%.*s_%lld", oname->len, oname->name, dir->i_ino); memcpy(oname->name, tmp_buf, name_len); oname->len = name_len;
Looks good. Reviewed-by: Viacheslav Dubeyko <redacted> Thanks, Slava.