Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}

On Sun, Jun 23, 2024 at 11:11 AM Matthew Wilcox [off-list ref] wrote:

On Sun, Jun 23, 2024 at 10:29:30AM +0800, Yafang Shao wrote:

quoted

On Fri, Jun 21, 2024 at 9:57 PM Matthew Wilcox [off-list ref] wrote:

quoted

On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote:

quoted

+++ b/mm/internal.h

Why are you putting __kstrndup in a header file when it's only used
in util.c?

I want to make it always inlined. However, it is not recommended to
define an inline function in a .c file, right ?

I'm not aware of any such recommendation.  Better than putting it in
a .h file that everybody has to look at but nobody uses.

Understood.
Will change it.

-- 
Regards
Yafang