Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul}

[PATCH v3 00/11] Improve the copy of task comm · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 01/11] fs/exec: Drop task_lock() inside __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 02/11] auditsc: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 03/11] security: Replace memcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 04/11] bpftool: Ensure task comm is always NUL-terminated · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 05/11] mm/util: Fix possible race condition in kstrdup() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Yafang Shao <hidden> · 2024-06-21
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Simon Horman <horms@kernel.org> · 2024-06-21
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Yafang Shao <hidden> · 2024-06-23
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Matthew Wilcox <willy@infradead.org> · 2024-06-21
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Yafang Shao <hidden> · 2024-06-23
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Matthew Wilcox <willy@infradead.org> · 2024-06-23
Re: [PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} · Yafang Shao <hidden> · 2024-06-23
[PATCH v3 07/11] mm/kmemleak: Replace strncpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 08/11] tsacct: Replace strncpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 09/11] tracing: Replace strncpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
Re: [PATCH v3 09/11] tracing: Replace strncpy() with __get_task_comm() · Masami Hiramatsu (Google) <mhiramat@kernel.org> · 2024-06-21
[PATCH v3 10/11] net: Replace strcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
[PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm() · Yafang Shao <hidden> · 2024-06-21
Re: [PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm() · Daniel Vetter <hidden> · 2024-06-21

From: Yafang Shao <hidden>
Date: 2024-06-23 02:30:07
Also in: bpf, dri-devel, linux-fsdevel, linux-mm, linux-trace-kernel, netdev, selinux

On Fri, Jun 21, 2024 at 9:57 PM Matthew Wilcox [off-list ref] wrote:

On Fri, Jun 21, 2024 at 10:29:54AM +0800, Yafang Shao wrote:

quoted

+++ b/mm/internal.h

Why are you putting __kstrndup in a header file when it's only used
in util.c?

I want to make it always inlined. However, it is not recommended to
define an inline function in a .c file, right ?

Also, I think this function is actually __kmemdup_nul(), not
__kstrndup().

Good suggestion. Will use __kmemdup_nul() instead.

-- 
Regards
Yafang

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help