On 7/22/20 1:02 PM, Joe Perches wrote:

On Wed, 2020-07-22 at 06:46 -0700, trix@redhat.com wrote:

quoted

From: Tom Rix <trix@redhat.com>

Reviewing use of memset in keyctrl_pkey.c

keyctl_pkey_params_get prologue code to set params up

	memset(params, 0, sizeof(*params));
	params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")

At best, this is a micro optimization.

Yes

How is this appropriate for a Fixes: line?

Removing unneeded code is not a fix?

quoted

diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c

[]

quoted

@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
 	struct kernel_pkey_query res;
 	long ret;
 
-	memset(&params, 0, sizeof(params));
-
 	ret = keyctl_pkey_params_get(id, _info, &params);
 	if (ret < 0)
 		goto error;