Re: [PATCH 1/2] crypto: rename sm3-256 to sm3 in hash_algo_name
From: Mimi Zohar <zohar@linux.ibm.com>
Date: 2020-02-10 17:42:31
Also in:
linux-crypto, linux-integrity, lkml
[Cc'ing Jarkko] On Mon, 2020-02-10 at 20:44 +0800, Tianjia Zhang wrote:
The name sm3-256 is defined in hash_algo_name in hash_info, but the algorithm name implemented in sm3_generic.c is sm3, which will cause the sm3-256 algorithm to be not found in some application scenarios of the hash algorithm, and an ENOENT error will occur. For example, IMA, keys, and other subsystems that reference hash_algo_name all use the hash algorithm of sm3. Signed-off-by: Tianjia Zhang <redacted>
Missing is the "Fixes" tag and Cc'ing the person who upstreamed "sm3- 256" in the first place. Mimi
quoted hunk ↗ jump to hunk
--- crypto/hash_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/crypto/hash_info.c b/crypto/hash_info.c index c754cb75dd1a..a49ff96bde77 100644 --- a/crypto/hash_info.c +++ b/crypto/hash_info.c@@ -26,7 +26,7 @@ const char *const hash_algo_name[HASH_ALGO__LAST] = { [HASH_ALGO_TGR_128] = "tgr128", [HASH_ALGO_TGR_160] = "tgr160", [HASH_ALGO_TGR_192] = "tgr192", - [HASH_ALGO_SM3_256] = "sm3-256", + [HASH_ALGO_SM3_256] = "sm3", [HASH_ALGO_STREEBOG_256] = "streebog256", [HASH_ALGO_STREEBOG_512] = "streebog512", };