Re: [RFC PATCH v14 05/10] fs,landlock: Support filesystem access-control

From
Jann Horn <jannh@google.com>
Date
2020-02-27 16:52:20
Also in
linux-api, linux-arch, linux-doc, linux-fsdevel, linux-kselftest, lkml
Reply to
Mickaël Salaün, 2020-02-27
On Thu, Feb 27, 2020 at 5:50 PM Mickaël Salaün [off-list ref] wrote:
On 26/02/2020 21:29, Jann Horn wrote:
quoted
On Mon, Feb 24, 2020 at 5:03 PM Mickaël Salaün [off-list ref] wrote:
quoted
+static inline u32 get_mem_access(unsigned long prot, bool private)
+{
+       u32 access = LANDLOCK_ACCESS_FS_MAP;
+
+       /* Private mapping do not write to files. */
+       if (!private && (prot & PROT_WRITE))
+               access |= LANDLOCK_ACCESS_FS_WRITE;
+       if (prot & PROT_READ)
+               access |= LANDLOCK_ACCESS_FS_READ;
+       if (prot & PROT_EXEC)
+               access |= LANDLOCK_ACCESS_FS_EXECUTE;
+       return access;
+}
[...]
However, I'm not sure this hook is useful for now. Indeed, the process
still need to have a file descriptor open with the right accesses.
Yeah, agreed.
Thread (34 messages) 34 messages, 5 authors, last reply 2020-03-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help