Re: [RFC PATCH v14 05/10] fs,landlock: Support filesystem access-control

From
Jann Horn <jannh@google.com>
Date
2020-02-26 20:29:47
Also in
linux-api, linux-arch, linux-doc, linux-fsdevel, linux-kselftest, lkml
Reply to
Mickaël Salaün, 2020-02-24
On Mon, Feb 24, 2020 at 5:03 PM Mickaël Salaün [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+static inline u32 get_mem_access(unsigned long prot, bool private)
+{
+       u32 access = LANDLOCK_ACCESS_FS_MAP;
+
+       /* Private mapping do not write to files. */
+       if (!private && (prot & PROT_WRITE))
+               access |= LANDLOCK_ACCESS_FS_WRITE;
+       if (prot & PROT_READ)
+               access |= LANDLOCK_ACCESS_FS_READ;
+       if (prot & PROT_EXEC)
+               access |= LANDLOCK_ACCESS_FS_EXECUTE;
+       return access;
+}
When I do the following, is landlock going to detect that the mmap()
is a read access, or is it incorrectly going to think that it's
neither read nor write?

$ cat write-only.c
#include <fcntl.h>
#include <sys/mman.h>
#include <stdio.h>
int main(void) {
  int fd = open("/etc/passwd", O_RDONLY);
  char *ptr = mmap(NULL, 0x1000, PROT_WRITE, MAP_PRIVATE, fd, 0);
  printf("'%.*s'\n", 4, ptr);
}
$ gcc -o write-only write-only.c -Wall
$ ./write-only
'root'
$
Thread (34 messages) 34 messages, 5 authors, last reply 2020-03-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help