Thread (30 messages) 30 messages, 6 authors, 2019-02-04

Re: Getting weird TPM error after rebasing my tree to security/next-general

From: Jarkko Sakkinen <hidden>
Date: 2019-01-31 18:47:49
Also in: linux-integrity, lkml

On Thu, Jan 31, 2019 at 09:43:42AM -0800, Linus Torvalds wrote:
On Thu, Jan 31, 2019 at 9:06 AM Jarkko Sakkinen
[off-list ref] wrote:
quoted
Found something that *does* fix the issue. If I replace memcpy_*io()
calls with regular memcpy(), the driver works and all my tests pass.
That's not surprising, since that's what we used to do. And it's
horribly wrong because "memcpy()" can do things that are horribly
wrong on IO accesses. Like doing them twice, but alternatively also
"copy one byte at a time" which generally works, but is horrendously
slow for IO.
Yup, was just a sanity check.
Can you check *which* memcpy_*io() triggers the issue? Maybe by
"bisecting" them (first perhaps on a file-by-file basis, and then
within a file).
Already did that. See my follow-up.

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help