Re: [RFC v2 11/13] keys/mktme: Program memory encryption keys on a system wide basis
From: Alison Schofield <alison.schofield@intel.com>
Date: 2018-12-05 17:24:05
Also in:
keyrings, linux-mm
On Wed, Dec 05, 2018 at 10:10:29AM +0100, Peter Zijlstra wrote:
On Tue, Dec 04, 2018 at 09:43:53PM -0800, Alison Schofield wrote:quoted
On Tue, Dec 04, 2018 at 10:21:45AM +0100, Peter Zijlstra wrote:quoted
On Mon, Dec 03, 2018 at 11:39:58PM -0800, Alison Schofield wrote:quoted
How is that serialized and kept relevant in the face of hotplug?mktme_leadcpus is updated on hotplug startup and teardowns.Not in this patch it is not. That is added in a subsequent patch, which means that during bisection hotplug is utterly wrecked if you happen to land between these patches, that is bad.
The Key Service support is split between 4 main patches (10-13), but the dependencies go further back in the patchset. If the bisect need outweighs any benefit from reviewing in pieces, then these patches can be squashed to a single patch: keys/mktme: Add the MKTME Key Service type for memory encryption keys/mktme: Program memory encryption keys on a system wide basis keys/mktme: Save MKTME data if kernel cmdline parameter allows keys/mktme: Support CPU Hotplug for MKTME keys Am I interpreting your point correctly? Thanks, Alison