Re: [PATCH 10/17] prmem: documentation
From: Nadav Amit <hidden>
Date: 2018-11-02 21:11:38
Also in:
linux-doc, linux-integrity, lkml
From: Nadav Amit Sent: November 1, 2018 at 4:31:59 PM GMT
To: Peter Zijlstra <peterz@infradead.org> Cc: Andy Lutomirski <luto@amacapital.net>, Matthew Wilcox <willy@infradead.org>, Kees Cook <redacted>, Igor Stoppa <redacted>, Mimi Zohar <redacted>, Dave Chinner <david@fromorbit.com>, James Morris <jmorris@namei.org>, Michal Hocko <mhocko@kernel.org>, Kernel Hardening <redacted>, linux-integrity <redacted>, linux-security-module <redacted>, Igor Stoppa <redacted>, Dave Hansen <dave.hansen@linux.intel.com>, Jonathan Corbet <corbet@lwn.net>, Laura Abbott <redacted>, Randy Dunlap <redacted>, Mike Rapoport <redacted>, open list:DOCUMENTATION <redacted>, LKML <redacted>, Thomas Gleixner <redacted> Subject: Re: [PATCH 10/17] prmem: documentation From: Peter Zijlstra Sent: October 31, 2018 at 9:08:35 AM GMTquoted
To: Nadav Amit <redacted> Cc: Andy Lutomirski <luto@amacapital.net>, Matthew Wilcox <willy@infradead.org>, Kees Cook <redacted>, Igor Stoppa <redacted>, Mimi Zohar <redacted>, Dave Chinner <david@fromorbit.com>, James Morris <jmorris@namei.org>, Michal Hocko <mhocko@kernel.org>, Kernel Hardening <redacted>, linux-integrity <redacted>, linux-security-module <redacted>, Igor Stoppa <redacted>, Dave Hansen <dave.hansen@linux.intel.com>, Jonathan Corbet <corbet@lwn.net>, Laura Abbott <redacted>, Randy Dunlap <redacted>, Mike Rapoport <redacted>, open list:DOCUMENTATION <redacted>, LKML <redacted>, Thomas Gleixner <redacted> Subject: Re: [PATCH 10/17] prmem: documentation On Tue, Oct 30, 2018 at 04:18:39PM -0700, Nadav Amit wrote:quoted
quoted
Nadav, want to resubmit your series? IIRC the only thing wrong with it was that it was a big change and we wanted a simpler fix to backport. But that’s all done now, and I, at least, rather liked your code. :)I guess since it was based on your ideas… Anyhow, the only open issue that I have with v2 is Peter’s wish that I would make kgdb use of poke_text() less disgusting. I still don’t know exactly how to deal with it. Perhaps it (fixing kgdb) can be postponed? In that case I can just resend v2.Oh man, I completely forgot about kgdb :/ Also, would it be possible to entirely remove that kmap fallback path?Let me see what I can do about it.
My patches had several embarrassing bugs. I’m fixing and will resend later, hopefully today.