Re: [PATCH v5 2/5] Smack: Prepare for PTRACE_MODE_SCHED

From
Jiri Kosina <jikos@kernel.org>
Date
2018-10-16 11:44:43
Also in
lkml
Reply to
Jann Horn, 2018-10-04
On Thu, 4 Oct 2018, Jann Horn wrote:
quoted
Well, we can't really call out into audit from scheduler code, and the
previous versions of the patchsets didn't have PTRACE_MODE_SCHED, so it
had to be included in PTRACE_MODE_IBPB in order to make sure we're not
calling into audit from context switch code.

Or did I misunderstand the question?
If I understand Casey correctly, he is saying that your patch
(https://lore.kernel.org/lkml/nycvar.YFH.7.76.1809251437340.15880@cbobk.fhfr.pm/ (local))
doesn't include PTRACE_MODE_NOAUDIT for IBPB, but the previous v6 of
your patch (https://lore.kernel.org/lkml/nycvar.YFH.7.76.1809121105330.15880@cbobk.fhfr.pm/ (local))
did include it, and therefore Casey thinks that there is a specific
reason why you removed PTRACE_MODE_NOAUDIT, 
Quite honestly, I don't remember. I dont't think there is any deadlock 
that'd be triggered by this.
and therefore Casey is adding special-case logic for PTRACE_MODE_SCHED 
to Smack when simply using PTRACE_MODE_NOAUDIT would also work.

I think that Casey should change ptrace_may_access_sched() to use
"mode | PTRACE_MODE_SCHED | PTRACE_MODE_NOAUDIT".
Agreed, that should work.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Thread (27 messages) 27 messages, 6 authors, last reply 2018-10-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help