[PATCH 01/13] selinux: Cleanup printk logging in conditional
From: paul@paul-moore.com (Paul Moore)
Date: 2018-06-19 15:46:39
Also in:
lkml, selinux
On Wed, Jun 13, 2018 at 2:23 AM peter enderborg [off-list ref] wrote:
On 06/12/2018 04:38 PM, Joe Perches wrote:quoted
On Tue, 2018-06-12 at 10:09 +0200, Peter Enderborg wrote:quoted
Replace printk with pr_* to avoid checkpatch warnings.I believe it would be nicer to remove the "SELinux: " prefix embbeded in each format and use a specific #define pr_fmt(fmt) "SELinux: " fmt to automatically prefix these formats.I cant argument about that, however some of the warnings and debug prints in this set does not have this so it will then change the actual output. (And I also think that they should have a the prefix, but I don't know why they don't) So I am not sure if it appropriate for a cleanup patch, it supposed to have no functional change.
As others have mentioned, I think this patch is still a step forward so I'm going to go ahead and merge it; thanks Peter. As far as the prefix, or lack of, is concerned, that's probably an oversight that we should fix at some point, but we would need to look at each instance to verify. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html