Thread (7 messages) 7 messages, 4 authors, 2021-08-19

Re: [PATCH v2 2/2] scsi: qla1280: Fix DEBUG_QLA1280 compilation issues

From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-08-19 18:07:57
Also in: lkml

On 8/19/21 2:32 AM, John Garry wrote:
quoted hunk ↗ jump to hunk
The driver does not compile under DEBUG_QLA1280 flag:
- Debug statements expect an integer for printing a SCSI lun value, but
   its size is 64b. So change SCSI_LUN_32() to cast to an int, as would be
   expected from a "_32" function.
- lower_32_bits() expects %x, as opposed to %lx, so fix that.

Also delete ql1280_dump_device(), which looks to have never been
referenced.

Signed-off-by: John Garry <redacted>
---
  drivers/scsi/qla1280.c | 27 ++-------------------------
  1 file changed, 2 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index b4f7d8d7a01c..9a7e84b49d41 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -494,7 +494,7 @@ __setup("qla1280=", qla1280_setup);
  #define CMD_HOST(Cmnd)		Cmnd->device->host
  #define SCSI_BUS_32(Cmnd)	Cmnd->device->channel
  #define SCSI_TCN_32(Cmnd)	Cmnd->device->id
-#define SCSI_LUN_32(Cmnd)	Cmnd->device->lun
+#define SCSI_LUN_32(Cmnd)	((int)Cmnd->device->lun)
How about using 'unsigned int' instead of 'int' since LUN numbers are 
positive integers?

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help