Thread (7 messages) 7 messages, 4 authors, 2021-08-19

Re: [PATCH v2 2/2] scsi: qla1280: Fix DEBUG_QLA1280 compilation issues

From: Hannes Reinecke <hare@suse.de>
Date: 2021-08-19 10:39:16
Also in: lkml

On 8/19/21 11:32 AM, John Garry wrote:
The driver does not compile under DEBUG_QLA1280 flag:
- Debug statements expect an integer for printing a SCSI lun value, but
   its size is 64b. So change SCSI_LUN_32() to cast to an int, as would be
   expected from a "_32" function.
- lower_32_bits() expects %x, as opposed to %lx, so fix that.

Also delete ql1280_dump_device(), which looks to have never been
referenced.

Signed-off-by: John Garry <redacted>
---
  drivers/scsi/qla1280.c | 27 ++-------------------------
  1 file changed, 2 insertions(+), 25 deletions(-)
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help