Thread (22 messages) 22 messages, 2 authors, 2021-07-09

RE: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member

From: <Don.Brace@microchip.com>
Date: 2021-07-08 21:18:18
Also in: lkml

From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] 
Subject: Re: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member

Dear Don, dear Mike,


Am 06.07.21 um 20:16 schrieb Don Brace:
From: Mike McGowen <redacted>

Correct driver's ISR accessing a data structure member that has not 
been fully initialized during driver init.
Does that crash the Linux kernel?
Don: 
No. I updated the title and description to reflect this. It resulted in some brief access to uninitialized members.
This was found during some internal testing, no bugs were ever filed for this change.
 
Thanks for your review.
   - The pqi queue groups can be null when an interrupt fires.
If it fixes a crash(?), please add a Fixes: tag so it can be backported to the stable series.



Kind regards,

Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help