Re: [PATCH v4 05/10] scsi: ufs: Remove a redundant tag check in ufshcd_queuecommand()
From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-06-23 21:24:45
Also in:
lkml
On 6/23/21 12:35 AM, Can Guo wrote:
Since commit a45f937110fa6b0c2c06a5d3ef026963a5759050 ("scsi: ufs: OptimizePlease shorten commit IDs to 12 characters.
quoted hunk ↗ jump to hunk
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5f837c4..3695dd2 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c@@ -2768,15 +2768,6 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) WARN_ON(ufshcd_is_clkgating_allowed(hba) && (hba->clk_gating.state != CLKS_ON)); - if (unlikely(test_bit(tag, &hba->outstanding_reqs))) { - if (hba->wlu_pm_op_in_progress) - set_host_byte(cmd, DID_BAD_TARGET); - else - err = SCSI_MLQUEUE_HOST_BUSY; - ufshcd_release(hba); - goto out; - }
I have never encountered code like the above in any other SCSI LLD. Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>