Re: [PATCH 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-12-13 01:34:26
Also in:
kexec, linux-fsdevel, lkml
On Mon, Dec 13, 2021 at 12:06:34AM +0000, Matthew Wilcox (Oracle) wrote:
quoted hunk ↗ jump to hunk
+++ b/arch/arm/kernel/crash_dump.c@@ -27,9 +27,8 @@ * @buf. If @buf is in userspace, set @userbuf to %1. Returns number of bytes * copied or negative error in case of failure. */ -ssize_t copy_oldmem_page(unsigned long pfn, char *buf, - size_t csize, unsigned long offset, - int userbuf) +ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn, + size_t csize, unsigned long offset) { void *vaddr;
I forgot to mention that I didn't adjust the kernel-doc. I'm tempted to remove it entirely, to be honest. It's not included into the rst files, and having the documentation repeated ten times across arch directories isn't useful.