Re: [PATCH v2 06/17] dt-bindings: rng: add bindings for microchip mpfs rng
From: conor dooley <hidden>
Date: 2021-12-17 16:26:30
Also in:
linux-crypto, linux-devicetree, linux-gpio, linux-i2c, linux-pwm, linux-riscv, linux-spi, linux-usb, lkml
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, December 17th, 2021 at 15:47, Krzysztof Kozlowski [off-list ref] wrote:
On 17/12/2021 16:22, Conor.Dooley@microchip.com wrote:quoted
On 17/12/2021 15:07, Krzysztof Kozlowski wrote:quoted
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 17/12/2021 15:53, Krzysztof Kozlowski wrote:quoted
On 17/12/2021 10:33, conor.dooley@microchip.com wrote:quoted
From: Conor Dooley conor.dooley@microchip.com Add device tree bindings for the hardware rng device accessed via the system services on the Microchip PolarFire SoC. Signed-off-by: Conor Dooley conor.dooley@microchip.com ------------------------------------------------------Three topics: 1. Node name (as most of others are using): rng 2. skip the label, not helping in example. 3. This looks very simple, so I wonder if the bindings are complete. No IO space/address... How is it going to be instantiated?OK, now I saw the usage in DTS. I have doubts this makes sense as separate bindings. It looks like integrated part of syscontroller, so maybe make it part of that binding? Or at least add ref to syscontroller bindings that such child is expected.Acking the rest of this, re: adding the ref: is what is being done in patch 03/17 insufficient?Ops, I missed the 03/17. Yeah, it looks it is sufficient and in such case I think you do not need this patch. The compatible is documented in 03/17. The same for sysserv.
Grand, that makes things easier. Conor.
Best regards, Krzysztof linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv