On Tue, Mar 16, 2021 at 12:52:51PM +0100, Henning Schild wrote:

Am Tue, 16 Mar 2021 13:30:36 +0200
schrieb Andy Shevchenko [off-list ref]:

quoted

On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote:

quoted

From: Johannes Hahn <redacted>

This allows the RX6110 driver to be automatically assigned to the
right device on the I2C bus.  

Thanks for all effort!
Reviewed-by: Andy Shevchenko <redacted>
after addressing the below comments.

quoted

Signed-off-by: Johannes Hahn <redacted>
Signed-off-by: Claudius Heine <redacted>  

quoted

Signed-off-by: Henning Schild <redacted>  

Claudius, just remove that. I guess just add yours and mention authors
in the code if they should receive some recognition.

quoted

quoted

+#ifdef CONFIG_ACPI
+static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
+	{ "SECC6110", },

quoted

quoted

+	{ },

Missed one thing, remove comma here. Terminator lines do not need a comma (and
it's theoretically may confuse people or scripts while adding a new record to
the array).

quoted

quoted

+};
+MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
+#endif

-- 
With Best Regards,
Andy Shevchenko