Thread (31 messages) 31 messages, 9 authors, 2021-03-17

Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

From: Andy Shevchenko <hidden>
Date: 2021-03-16 11:33:50
Also in: lkml

On Tue, Mar 16, 2021 at 01:30:36PM +0200, Andy Shevchenko wrote:
On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote:
quoted
From: Johannes Hahn <redacted>

This allows the RX6110 driver to be automatically assigned to the right
device on the I2C bus.
Thanks for all effort!
Reviewed-by: Andy Shevchenko <redacted>
after addressing the below comments.
quoted
Signed-off-by: Johannes Hahn <redacted>
Signed-off-by: Claudius Heine <redacted>
quoted
Signed-off-by: Henning Schild <redacted>
I think this is somehow confusing. Either you need to add Co-developed-by of
the corresponding people, or remove SoB (because of From line), i.o.w seems
like Co-dB tag is needed for Johannes or you and something should be done with
Henning's SoB.
Since Johannes' name is in the From, then it seems okay for you (either you a
co-developer, than a Co-dB tag, or a submitter, than it's okay to have no Co-dB
tag).


-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help