[rtc-linux] Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device
From: Logan Gunthorpe <logang@deltatee.com>
Date: 2017-02-21 06:35:21
Also in:
linux-fsdevel, linux-gpio, linux-input, linux-rdma, linux-scsi, nvdimm
Possibly related (same subject, not in this thread)
- 2017-02-21 · Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Logan Gunthorpe <hidden>
- 2017-02-21 · Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Dan Williams <hidden>
- 2017-02-21 · [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Logan Gunthorpe <hidden>
On 20/02/17 10:35 PM, Dmitry Torokhov wrote:
My only objection is to this statement. There is absolutely nothing that prevents from calling device_unregister() first and cdev_del() later. Refcounting will sort it all out.
Yeah, I was really trying to warn people against calling cdev_del within the release function of the device. If you do that, then the cdev reference will block the device from ever getting released. Certainly, you could call device_unregister followed by cdev_del. I could reword this if you feel it necessary. Logan -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.