Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device
From: Logan Gunthorpe <hidden>
Date: 2017-02-21 06:35:21
Also in:
linux-fsdevel, linux-gpio, linux-rdma, linux-rtc, linux-scsi, nvdimm
Possibly related (same subject, not in this thread)
- 2017-02-21 · Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Logan Gunthorpe <hidden>
- 2017-02-21 · Re: [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Dan Williams <hidden>
- 2017-02-21 · [PATCH 01/14] chardev: add helper function to register char devs with a struct device · Logan Gunthorpe <hidden>
On 20/02/17 10:35 PM, Dmitry Torokhov wrote:
My only objection is to this statement. There is absolutely nothing that prevents from calling device_unregister() first and cdev_del() later. Refcounting will sort it all out.
Yeah, I was really trying to warn people against calling cdev_del within the release function of the device. If you do that, then the cdev reference will block the device from ever getting released. Certainly, you could call device_unregister followed by cdev_del. I could reword this if you feel it necessary. Logan