Thread (12 messages) 12 messages, 3 authors, 2016-08-15

[rtc-linux] Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.

From: <hidden>
Date: 2016-08-11 14:56:03


Den torsdag 11 augusti 2016 kl. 15:42:58 UTC+2 skrev alexandre.belloni:
On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote : 
quoted
From: Jan Östlund <j...@hms.se <javascript:>> 

The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same 
value. This is no functional change. 

Signed-off-by: Daniel Romell <da...@hms.se <javascript:>> 
Sorry, I saw it only before trying apply but both patches also need Jan's 
SoB. 
Ah, sorry, my bad. I'll ask him to add that. 
Is it ok if he just reply to the emails with his SoB line, or do you need a 
new patch set?  
quoted
--- 
 drivers/rtc/rtc-bq32k.c | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 
diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c 
index 0299988..5a0c137 100644 
--- a/drivers/rtc/rtc-bq32k.c 
+++ b/drivers/rtc/rtc-bq32k.c 
@@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, 
struct rtc_time *tm) 
quoted
                 return error; 
  
         tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); 
-        tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); 
+        tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); 
         tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); 
         tm->tm_mday = bcd2bin(regs.date); 
         tm->tm_wday = bcd2bin(regs.day) - 1; 
-- 
2.7.4 
-- 
Alexandre Belloni, Free Electrons 
Embedded Linux and Kernel engineering 
http://free-electrons.com 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help