[rtc-linux] Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.
From: Alexandre Belloni <hidden>
Date: 2016-08-11 13:43:02
Also in:
lkml
On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote :
From: Jan =C3=96stlund <redacted> =20 The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same value. This is no functional change. =20 Signed-off-by: Daniel Romell <redacted>
Sorry, I saw it only before trying apply but both patches also need Jan's S= oB.
quoted hunk ↗ jump to hunk
--- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) =20diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 0299988..5a0c137 100644 --- a/drivers/rtc/rtc-bq32k.c +++ b/drivers/rtc/rtc-bq32k.c@@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, stru=
ct rtc_time *tm)
return error; =20 tm->tm_sec =3D bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); - tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); + tm->tm_min =3D bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); tm->tm_hour =3D bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); tm->tm_mday =3D bcd2bin(regs.date); tm->tm_wday =3D bcd2bin(regs.day) - 1; --=20 2.7.4 =20
--=20 Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.