On Wed, Jan 13, 2016 at 05:35:33PM +0530, Laxman Dewangan wrote:

On Wednesday 13 January 2016 05:27 PM, Mark Brown wrote:

quoted

quoted

Something below. This will do the pre configuration before
regulator_register happena dn machine constraint sets.
I can not use the init_data->regulator_init() as I need to have the init
data passed to the driver.

quoted

Why do you have this requirement?

This is require to
- configure FPS_SRC based on platform data for each rail,
    - If FPS_SRC enabled then enable it always.
    - If FPS_SRC is disabled (NONE) then based on init data constraint,
      set it to desired state.

What is FPS_SRC and why is it set from init_data?  A driver should never
be looking at init_data.

- Power mode and slew rate init based on default configuration from the
register if platform does not want to set it.

Same here, why is init_data needed here?

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.