Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

On 11/25/21 15:20, Steven Rostedt wrote:

On Thu, 25 Nov 2021 14:45:30 +0100
Daniel Bristot de Oliveira [off-list ref] wrote:

quoted

quoted

Or do you think that 1d should be the default, and we have:

	tracefs_hist_alloc()	-- 1d histogram
	tracefs_hist_alloc_2d()	-- 2d histogram
	tracefs_hist_alloc_nd()	-- Nd histogram?

??  

IMHO, the function names in your second email sound more intuitive, i.e.,
tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd().

quoted

We haven't tagged it yet, so we could change it again (and then your code
will work as is).  

two birds with a single stone :-)

Just to confirm (confused by "second email" above), you prefer that we
update the API to:

	tracefs_hist_alloc()
	tracefs_hist_alloc_2d()
	tracefs_hist_alloc_nd()

Right?

Right!

-- Daniel

Thanks,

-- Steve