Thread (13 messages) 13 messages, 5 authors, 2021-08-06

Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()

flat view

From: John Ogness <john.ogness@linutronix.de>
Date: 2021-07-20 14:21:21
Also in: lkml

On 2021-07-20, Joe Perches [off-list ref] wrote:
Logic continuations are typically at the end of the previous line.
And there are few too many parentheses for my taste.

Maybe exceed 80 columns in a single line

	may_sleep = preemptible() && !in_softirq() && system_state >= SYSTEM_RUNNING;

or align the continuation

	may_sleep = (preemptible() && !in_softirq() &&
		     system_state >= SYSTEM_RUNNING);

or use individual lines

	may_sleep = (preemptible() &&
		     !in_softirq() &&
		     system_state >= SYSTEM_RUNNING);
The kernel now has a 100-column policy, but I decided to go with this
third variant for easy reading.

Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank
you.

John Ogness
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help